Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC #9: clarify that .const() can return a value-castable. #29

Merged
merged 1 commit into from
Oct 9, 2023
Merged

RFC #9: clarify that .const() can return a value-castable. #29

merged 1 commit into from
Oct 9, 2023

Conversation

zyp
Copy link
Contributor

@zyp zyp commented Oct 6, 2023

No description provided.

@whitequark whitequark added the meta:nominated Nominated for discussion on the next relevant meeting label Oct 7, 2023
whitequark
whitequark previously requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

@whitequark whitequark self-requested a review October 9, 2023 16:57
@whitequark
Copy link
Member

We have discussed this on the 2023-10-09 weekly meeting. The disposition was to merge.

@whitequark whitequark removed the meta:nominated Nominated for discussion on the next relevant meeting label Oct 9, 2023
@whitequark whitequark merged commit 4fbed5f into amaranth-lang:main Oct 9, 2023
@zyp zyp mentioned this pull request Oct 10, 2023
Merged
@whitequark whitequark added the area:core RFC affecting APIs in amaranth-lang/amaranth label Nov 22, 2023
@zyp zyp deleted the const-value-castable branch December 10, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
area:core RFC affecting APIs in amaranth-lang/amaranth
Milestone
No milestone
2 participants
@zyp @whitequark