Update fsevents dep

[chaffeqa]

fsevents@1.2.3 contains a fix for nodev10. This prevents any installation of jest since it tries to pull in sane@^2.0.0 and then finds the non-optional fsevents, which blows up.

I'm also opening a issue in jest refering to this (since I think the updating to sane@^2.5.0 will make it trully optional/opt-in-only).

I think both groups should be aware

[stefanpenner]

Thanks for letting us know.

Question for you, since we have a ^1.1.1 dep on fsevents, and 1.2.3 contains the fix. Do we have any action items on our end?

[SimenB]

It's useful to bump as doing deep upgrades is not the easiest, especially if current versions are important to keep for other deps.

But it is possible for consumers to update themselves

[stefanpenner]

It's useful to bump as doing deep upgrades is not the easiest, especially if current versions are important to keep for other deps.

isn't the fix simply reinstalling + deleting lock files?

[stefanpenner]

Not that I actually don't agree, we should just bump. It comes at little risk, I want to just understand the above ^.

[chaffeqa]

Honestly I don't think I arrived at a suggest-able solution. It's a pretty intricate and deep problem, in lieu of a quick solution coming to mind, I just decided to log it to relevent parties.

My of-the-top-of-the-head solution would be:

• Bump the fsevents optional dep to ^1.2.3, and release an appropriate semvar version update which if I'm not mistaken, is patch level since updating sane in a project won't automatically update the fsevents

I may be wrong, either way though my hunch is the correct fix is jestjs/jest#6123

[chaffeqa]

👍 thanks for the quick turnaround!

[stefanpenner]

released as v2.5.1 🎉

[stefanpenner]

👍 thanks for the quick turnaround!

Absolutely!

[SimenB]

isn't the fix simply reinstalling + deleting lock files?

Yes, if it's acceptable to dump the lock files - that's not a given 🙂 We ended up bumping some Istanbul deps in Jest even though they were in semver range as the upgrade internally at FB apparently was difficult (jestjs/jest#5772 (comment))