Use micromatch and bump anymatch.
#115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stefanpenner can you plz take a peak? |
stefanpenner
requested changes
Mar 16, 2018
There was a problem hiding this comment.
Readme should be updated, as it contains references to minimatch: https://github.com/amasad/sane/search?utf8=%E2%9C%93&q=minimatch&type=
package.json
Outdated
| "exec-sh": "^0.2.0", | ||
| "fb-watchman": "^2.0.0", | ||
| "micromatch": "^3.1.4", | ||
| "minimatch": "^3.0.2", |
There was a problem hiding this comment.
should likely remove this dependency
|
I left 2 recommendations, once addressed this LGTM. |
|
Updated to address PR review. |
stefanpenner
approved these changes
Mar 16, 2018
|
released as v2.5.0 🎉 |
lukaw3d
added a commit
to lukaw3d/gulp-sane-watch
that referenced
this pull request
Jul 13, 2018
Windows globs broke after `sane` migrated from minimatch to micromatch v3 amasad/sane#115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For real this time.