Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support micromatch patterns in watchman #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support micromatch patterns in watchman #147

wants to merge 1 commit into from

Conversation

conartist6
Copy link

Fixes #145.

@conartist6 conartist6 force-pushed the watchman-micromatch branch 4 times, most recently from da6a865 to ca3a88d Compare July 4, 2019 22:03
@conartist6
Copy link
Author

So I have two options I think. I could upgrade micromatch to v4 and use their parse API to determine if a particular glob expression is supported, or I could use glob-parse.

The drawback to upgrading micromatch is that it requires node8, and as far as I can tell sane is still making an effort to support node versions far below 8.

Thoughts?

@conartist6
Copy link
Author

This is now the version of the PR which would need micromatch@4.

@conartist6 conartist6 mentioned this pull request Jul 4, 2019
Open
@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg mentioned this pull request Aug 17, 2019
Closed
@stefanpenner
Copy link
Collaborator

@conartist6 I'm good with dropping old versions of node, but all new features require some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watchman does not understand micromatch globs
2 participants
@conartist6 @stefanpenner