Decorate associations of a decorated object

[ronen]

Hi, I just started using active_decorator, it seems great, thanks for making it!

But I quickly came across a feature that I needed: the ability to access an association's decorations. That is, considering the Book and Author classes in spec/fake_app -- I wanted to create a method in BookDecoration like:

def attribution
     "#{title}, by #{author.capitalized_name}"
end

which uses AuthorDecoration#capitalized_name. But typically although self is decorated, se;f.author is not decorated so the method fails.

The solution I came up with is, after decorating an object, to introspect on all associations and override their methods in the object's singleton class, to call super() and return the decorated result. This approach seems to work, and has the feature of being "lazy" in that the associated objects only get decorated if/when they're accessed. I don't think it will conflict with anything else, though I'll admit I haven't put very deep thought into it.

Cheers

[auxout]

+1

[kinopyo]

+1

[soycamo]

👍

[damien-roche]

Is somebody going to accept this pull request? I'm having to use ronen's repo (thanks ronen).

[icortex]

+1

[y-yagi]

👍

[koko1000ban]

👍

[kenchan]

👍

[ken1flan]

👍

[mshibuya]

@amatsuda Is there any specific reason not to merging this?
I don't believe ActiveDecorator should be lacking in such a fundamental feature.

If the only problem is merge conflict, I'll resolve and open another PR.

[vala]

@amatsuda could you please review this PR too ?

[amatsuda]

After 5 years since the first proposal, this feature has been finally introduced since 0.9.0 gem! v0.8.0...v0.9.0
I'm so sorry that I couldn't make this happen earlier, but I hope you all enjoy this new feature!