remove unused href and add classes #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe it is intended to be that way since bootstrap does not use gap or page classes on the pagination li's by default. I agree that we can remove the href attributes, but why remove the rails_helper methods? Perhaps we can leverage them even further with something like this: <%= content_tag :li, link_to( raw(t 'views.pagination.truncate')), class: :disabled %> |
| <li class="disabled"> | ||
| <%= link_to raw(t 'views.pagination.truncate'), '#' %> | ||
| <li class="page gap disabled"> | ||
| <a><%= raw(t 'views.pagination.truncate') %></a> |
There was a problem hiding this comment.
why did you remove the helper ?
There was a problem hiding this comment.
I think that link_to helper cannot omit href.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bootstrap theme, href attributes are unnecessary.
And page and gap classes are missing.