remove unused href and add classes #12

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

znz commented Nov 19, 2012

In bootstrap theme, href attributes are unnecessary.
And page and gap classes are missing.

Contributor

jgrevich commented Mar 19, 2013

I believe it is intended to be that way since bootstrap does not use gap or page classes on the pagination li's by default.

I agree that we can remove the href attributes, but why remove the rails_helper methods? Perhaps we can leverage them even further with something like this:

<%= content_tag :li, link_to( raw(t 'views.pagination.truncate')), class: :disabled %>

@seuros seuros commented on the diff Sep 9, 2014

bootstrap/app/views/kaminari/_gap.html.erb
@@ -1,3 +1,3 @@
-<li class="disabled">
- <%= link_to raw(t 'views.pagination.truncate'), '#' %>
+<li class="page gap disabled">
+ <a><%= raw(t 'views.pagination.truncate') %></a>
@seuros

seuros Sep 9, 2014

Collaborator

why did you remove the helper ?

@znz

znz Sep 11, 2014

I think that link_to helper cannot omit href.

@seuros seuros commented on the diff Sep 11, 2014

bootstrap/app/views/kaminari/_gap.html.erb
@@ -1,3 +1,3 @@
-<li class="disabled">
- <%= link_to raw(t 'views.pagination.truncate'), '#' %>
+<li class="page gap disabled">
+ <a><%= raw(t 'views.pagination.truncate') %></a>
</li>
@seuros

seuros Sep 11, 2014

Collaborator

we should not omit it. ' javascript:; '

seuros closed this Nov 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment