Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override default @empty behaviour. #1333

Closed
steveworley opened this issue Oct 22, 2019 · 0 comments · Fixed by #1334
Closed

Override default @empty behaviour. #1333

steveworley opened this issue Oct 22, 2019 · 0 comments · Fixed by #1334

Comments

@steveworley
Copy link
Contributor

Describe the bug
We have a clear default favicon that we want to use if none is specified. The = /favicon.ico location doesn't allow us to define a supplementary configuration to handle overriding the favicon.

I understand that this is suitable for 99% of users, if we declared the favicon handler in a separate file we could easily override for our use case and keep the configuration simple for the base.

To Reproduce
Steps to reproduce the behaviour:

  1. Add a server include to declare a location for /favicon.ico with a try_files directive to the local
  2. Navigate to /favicon.ico

Expected behavior

  1. Ability to change behaviour of @empty or location = /favicon.ico
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant