Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Makefile and php Dockerfiles to pin correct Apline version for php 7.0 #1136

Merged
merged 5 commits into from Jul 12, 2019

Conversation

@cdchris12
Copy link
Contributor

commented Jul 3, 2019

Updating makefile and php Dockerfiles to pin correct apline version for php 7.0. Upstream naming has changed from php:7.0-fpm-alpine to php:7-fpm-alpine, so our current version of alpine in the PHP containers is about 6 months behind where it should be.

Changelog Entry

Change - Updated makefile and php Dockerfiles to pin correct apline version for php 7.0

Closing issues

Closes #1111

@cdchris12 cdchris12 requested a review from Schnitzel Jul 3, 2019

@cdchris12

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

@Schnitzel The tests pass, and this one should be good to merge now. :)

images/php/fpm/Dockerfile Outdated Show resolved Hide resolved
images/php/fpm/Dockerfile Outdated Show resolved Hide resolved
images/php/fpm/Dockerfile Outdated Show resolved Hide resolved

@Schnitzel Schnitzel merged commit 97f8700 into master Jul 12, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@Schnitzel Schnitzel added this to the v1.0.0 RBAC milestone Aug 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.