Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1021 document lagoon base docker images #1323
#1021 document lagoon base docker images #1323
Changes from 6 commits
72b2ff6
f94f1e5
2286226
6120ee0
61a42b6
d4d1172
383be4f
904aef0
12f33a8
2efde96
e6f36c2
ff85191
04b8007
d47f16c
590ce8a
ab8db44
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would document this more clearer, the files are not called
prepend*.conf
but instead/etc/nginx/conf.d/drupal/server_prepend*.conf;
/etc/nginx/conf.d/drupal/location_prepend*.conf;
/etc/nginx/conf.d/drupal/location_drupal_prepend*.conf;
so I would go a bit into the detail what each of these files does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Can you review please?