Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for PHP 7.4 Release #1417

Merged
merged 8 commits into from Dec 1, 2019
Merged

Preparing for PHP 7.4 Release #1417

merged 8 commits into from Dec 1, 2019

Conversation

@dasrecht
Copy link
Member

dasrecht commented Nov 19, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Preparations for PHP 7.4 release.

  • PHP 7.4 needs libgcrypt-dev to sucessfully compile the xsl package
  • Disabling NewRelic installation for PHP 7.4 as it's not compatible yet
  • Adding NR_INSTALL_SILENT to not install NewRelic interactive

I've created this as draft pull request so we can update the branch to the latest RC candidate and see if the images run trough. As soon as PHP 7.4 releases we can switch over to the release version and release the images to master.

Changelog Entry

Feature - Support for PHP 7.4

Closing issues

closes #1406

dasrecht and others added 8 commits Nov 16, 2019
adding libgcrypt-dev (because under php 7.4 the xsl extension didn't build anymore)
skipping newrelic installation on php 7.4 because it's not yet compatible
adding NR_INSTALL_SILENT to the newrelic installation
@dasrecht dasrecht requested a review from Schnitzel Nov 29, 2019
@dasrecht dasrecht marked this pull request as ready for review Nov 29, 2019
@Schnitzel Schnitzel added this to the v1.2.0 milestone Dec 1, 2019
@Schnitzel Schnitzel merged commit 40efb1d into master Dec 1, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@dasrecht dasrecht deleted the php_74 branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.