Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PECL Yaml 2.1.0 to the base PHP images #2057

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Add PECL Yaml 2.1.0 to the base PHP images #2057

merged 1 commit into from
Jul 20, 2020

Conversation

seanhamlin
Copy link
Contributor

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Explain the details for making this change. What existing problem does the pull request solve?

Adds the PECL Yaml extension into the base PHP images. The extension supports PHP 7.1.0+, so it should build fine on all supported images.

Drupal 8 will make use of this extension automatically for all Yaml reads.

Closing issues

Closes #2056

@seanhamlin seanhamlin added the 6-images-testing Base Images & Testing subsystem label Jul 9, 2020
Copy link
Member

@smlx smlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests pass

@Schnitzel Schnitzel added this to the v1.8.2 milestone Jul 20, 2020
@Schnitzel Schnitzel merged commit 5920625 into master Jul 20, 2020
@tobybellwood tobybellwood deleted the yaml-pecl branch September 10, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-images-testing Base Images & Testing subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PECL Yaml extension for faster YAML parsing
3 participants