841 disable git sha injection #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to check: we would like to have still access to the SHA during build time |
|
I suppose rather than setting/unsetting the SHA in build-deploy.sh, we could set the value back to 0s when each service is deployed in build-deploy-docker-compose.sh? |
Schnitzel
requested changes
Feb 22, 2019
Schnitzel
added a commit
that referenced
this pull request
Feb 26, 2019
841 disable git sha injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changelog Entry
#841
Change - disable the injection of the deployed SHA in the
LAGOON_GIT_SHAenvironment variable.Adds - .lagoon.yml option
environment_variables.git_shato have the deployed SHA set.Closing issues
Closes #841