Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

841 disable git sha injection #879

Merged
merged 8 commits into from Feb 27, 2019

Conversation

Projects
None yet
2 participants
@twardnw
Copy link
Member

twardnw commented Feb 5, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Changelog Entry

#841

Change - disable the injection of the deployed SHA in the LAGOON_GIT_SHA environment variable.
Adds - .lagoon.yml option environment_variables.git_sha to have the deployed SHA set.

Closing issues

Closes #841

@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Feb 7, 2019

need to check: we would like to have still access to the SHA during build time

@twardnw

This comment has been minimized.

Copy link
Member Author

twardnw commented Feb 19, 2019

I suppose rather than setting/unsetting the SHA in build-deploy.sh, we could set the value back to 0s when each service is deployed in build-deploy-docker-compose.sh?

Show resolved Hide resolved images/oc-build-deploy-dind/build-deploy.sh Outdated
Show resolved Hide resolved tests/tests/features/disable-inject-git-sha.yaml Outdated

@Schnitzel Schnitzel self-assigned this Feb 22, 2019

Schnitzel added some commits Feb 22, 2019

Schnitzel added a commit that referenced this pull request Feb 26, 2019

@Schnitzel Schnitzel merged commit 5d7a961 into master Feb 27, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.