Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tables; fix typos and markup #9

Merged
merged 3 commits into from
Sep 28, 2020

Conversation

bob-carpenter
Copy link

@bob-carpenter bob-carpenter commented Aug 23, 2020

For the markdown version of the SRD, this pull request

  • adds the tables that were missing,

  • fixes typos, removes extra vertical space,

  • pulls punctuation/spaces out of game-terms, and

  • removes classgame-term CharOverride that was only used for punctuation.

I filed issue #8 because I wasn't 100% sure what the definition of "game-term" was meant to be. I tried hard to mark things that are currently marked up with <span class="game-term">...</span> as game terms.

The rendered version can be viewed on my fork of the repo.

@jpittman
Copy link

Thanks for going through and doing this. I'm currently working on a template doc the SRD for Scrivener and your updates/corrections have been a big help. Hopefully this gets into the main repo.

@bob-carpenter
Copy link
Author

@jpittman: You're welcome! I'm glad you found it useful.

@amazingrando --- Is there something else I could do to make this easier to review?

@amazingrando
Copy link
Owner

@bob-carpenter Reviewing this fell off of my todo list. I'm merging it now.

@amazingrando amazingrando merged commit fe465d4 into amazingrando:main Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants