-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change annealing quadratic keys to strings #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because JSON doesn't support tuple keys
kshitijc
approved these changes
Jan 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the version with the dict better since it:
- Implicitly enforces duplicate definitions (defining the same tuple twice).
- Preserves typing information.
- Avoids having to deal with issues like differentiating "1,2" / '1, 2".
avawang1
approved these changes
Jan 17, 2020
In regards to benefits regarding the string approach:
|
math411
pushed a commit
that referenced
this pull request
Feb 27, 2022
* feature: support for StartPreserveBlock and EndPreserveBlock instructions. (#94) * prepare release v1.3.0 * update development version to v1.3.1.dev0 * Update copyright headers (#95) * feature: StartVerbatimBox and EndVerbatimBox (#96) Added the StartVerbatimBox and EndVerbatimBox instructions. The code between the start and end instructions will not be modified by the compiler, thus delineating a "verbatim" box of code. The astute reader will notice that this is merely a renaming of the instructions StartVerbatimBlock and EndVerbatimBlock; this change is marked as a feature to emphasize the incompatibility with v1.3.0. * prepare release v1.4.0 * update development version to v1.4.1.dev0 * doc: Fix jaqcd typo in README.md (#97) * prepare release v1.4.0.post0 * update development version to v1.4.1.dev0 * Fix: Pin pydantic and jsonschema versions (#98) * prepare release v1.4.1 * update development version to v1.4.2.dev0 * added openqasm program and device capability. * OpenQASM support initial commit. * added rigetti/ionq tests; added result_type.py * updated README.md * reformatted. * removed unused import. * reformatted docstring in openqasm_device_action_properties.py * reformatted. * [fix] updated docstring. * [fix] incoporate Kshitij's comments. * added openqasm schema header in test_schema_base.py * reformatted. * reformatted. * turn off flake8 for jaqcd results/shared_models import alias. * updated jaqcd __init__.py to support import results from jaqcd folder. * empty commit to test github checker. * empty commit 2 to test github checker. * Merging in changes from main and updating imports for OpenQASM * Fixing names and defaults to match docs * Reformatted with `black` * Bring in internal changes * Merge changes from the internal repository (#8) * Fix typo in supportsPhysicalQubits cr: https://code.amazon.com/reviews/CR-61878135 * Removing `results` from OpenQASM Program cr: https://code.amazon.com/reviews/CR-62355578 * Reformat files Co-authored-by: Srikrishna Jaliparthy <jalipart@amazon.com> Co-authored-by: Jeffrey Heckey <heckey@amazon.com> * fix: Revert to old module structure (#9) Co-authored-by: Sergei-kag-aws <kag@amazon.com> Co-authored-by: ci <ci> Co-authored-by: Cody Wang <speller26@gmail.com> Co-authored-by: Jacky Ko <60188942+kjacky@users.noreply.github.com> Co-authored-by: Jeffrey Heckey <heckey@amazon.com> Co-authored-by: shiyunon <shiyunon@amazon.com> Co-authored-by: Jeff Heckey <jheckey@gmail.com> Co-authored-by: ℂ𝓞𝔇𝚈 <caw@amazon.com> Co-authored-by: Srikrishna Jaliparthy <jalipart@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because JSON doesn't support tuple keys