Add Unitary Gate #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avawang1
reviewed
Feb 19, 2020
| matrix: conlist( | ||
| conlist( | ||
| conlist(confloat(gt=float("-inf"), lt=float("inf")), min_items=2, max_items=2), | ||
| min_items=1, |
There was a problem hiding this comment.
Shouldn't it be min_items=2 for both of these to be valid and to be used on target qubits? Also, why list for the complex number and not tuple?
There was a problem hiding this comment.
I meant for this to represent a general two-dimensional non-empty matrix. The operators using these matrices are validating whether these have the correct dimensions based on the length of the supplied target.
Tuples are serialized as lists, so I thought it would be clearer to specify them as lists here. I can change this to tuples if there's an upside.
There was a problem hiding this comment.
I see your point. 1x1 gates are possible though not widely used, but I also found some mention of them in a paper online. Works for me.
avawang1
approved these changes
Feb 19, 2020
math411
pushed a commit
that referenced
this pull request
Feb 27, 2022
* feature: support for StartPreserveBlock and EndPreserveBlock instructions. (#94) * prepare release v1.3.0 * update development version to v1.3.1.dev0 * Update copyright headers (#95) * feature: StartVerbatimBox and EndVerbatimBox (#96) Added the StartVerbatimBox and EndVerbatimBox instructions. The code between the start and end instructions will not be modified by the compiler, thus delineating a "verbatim" box of code. The astute reader will notice that this is merely a renaming of the instructions StartVerbatimBlock and EndVerbatimBlock; this change is marked as a feature to emphasize the incompatibility with v1.3.0. * prepare release v1.4.0 * update development version to v1.4.1.dev0 * doc: Fix jaqcd typo in README.md (#97) * prepare release v1.4.0.post0 * update development version to v1.4.1.dev0 * Fix: Pin pydantic and jsonschema versions (#98) * prepare release v1.4.1 * update development version to v1.4.2.dev0 * added openqasm program and device capability. * OpenQASM support initial commit. * added rigetti/ionq tests; added result_type.py * updated README.md * reformatted. * removed unused import. * reformatted docstring in openqasm_device_action_properties.py * reformatted. * [fix] updated docstring. * [fix] incoporate Kshitij's comments. * added openqasm schema header in test_schema_base.py * reformatted. * reformatted. * turn off flake8 for jaqcd results/shared_models import alias. * updated jaqcd __init__.py to support import results from jaqcd folder. * empty commit to test github checker. * empty commit 2 to test github checker. * Merging in changes from main and updating imports for OpenQASM * Fixing names and defaults to match docs * Reformatted with `black` * Bring in internal changes * Merge changes from the internal repository (#8) * Fix typo in supportsPhysicalQubits cr: https://code.amazon.com/reviews/CR-61878135 * Removing `results` from OpenQASM Program cr: https://code.amazon.com/reviews/CR-62355578 * Reformat files Co-authored-by: Srikrishna Jaliparthy <jalipart@amazon.com> Co-authored-by: Jeffrey Heckey <heckey@amazon.com> * fix: Revert to old module structure (#9) Co-authored-by: Sergei-kag-aws <kag@amazon.com> Co-authored-by: ci <ci> Co-authored-by: Cody Wang <speller26@gmail.com> Co-authored-by: Jacky Ko <60188942+kjacky@users.noreply.github.com> Co-authored-by: Jeffrey Heckey <heckey@amazon.com> Co-authored-by: shiyunon <shiyunon@amazon.com> Co-authored-by: Jeff Heckey <jheckey@gmail.com> Co-authored-by: ℂ𝓞𝔇𝚈 <caw@amazon.com> Co-authored-by: Srikrishna Jaliparthy <jalipart@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Unitarygate which accepts a list of targets and a two dimensional matrix. The matrix specifies how the system evolves under the action of the gate.TwoDimensionalMatrixmodel for specifying a two dimensional matrix with complex entries. Each complex entry is represented using aList[float]of size 2, withelement[0]specifying the real part andelement[1]specifying the imaginary part. (Pydantic doesn't support python'scomplexdatatype).MultiTargetmodel to support >= 1 targets instead of >= 2.MultiControlmodel to match theMultiTargetspecification.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.