Option to write 32-bit floats when possible #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the Ion binary writer to write a `double` value with only 32 bits for the number instead of 64 wherever this is losslessly possible.
tgregg
previously approved these changes
Apr 23, 2021
test/test_ion_binary.cpp
Outdated
| // 0100 0000 1000 0110 0110 0110 0110 0110 | ||
| // 4 0 8 6 6 6 6 6 | ||
| test_ion_binary_writer_supports_compact_floats(TRUE, truncated, "\xE0\x01\x00\xEA\x44\x40\x86\x66\x66", 9); | ||
| } |
tgregg
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the Ion binary writer to write a
doublevalue with only 32 bits for the number instead of 64 wherever this is losslessly possible.Issue #, if available: Referenced in #139.
Description of changes: Add an option to specify a compact floats preference, and corresponding tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.