Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create interfaces for IonDotnet.Tree #30

Merged
merged 12 commits into from
Dec 17, 2019

Conversation

avneet-toor-bq
Copy link
Contributor

@avneet-toor-bq avneet-toor-bq commented Dec 16, 2019

Issue #, if available: #17 #18

Description of changes:

  • Created interfaces for the various IonXXX types in IonDotnet.Tree package
  • Constructors for various IonXXX types put in ValueFactory.cs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

IonDotnet/Tree/Impl/ValueFactory.cs Outdated Show resolved Hide resolved
IonDotnet/Tree/Impl/ValueFactory.cs Outdated Show resolved Hide resolved
IonDotnet/Tree/Impl/ValueFactory.cs Show resolved Hide resolved
IonDotnet/Tree/Impl/ValueFactory.cs Outdated Show resolved Hide resolved
IonDotnet/Tree/IValueFactory.cs Outdated Show resolved Hide resolved
@tgregg
Copy link
Contributor

tgregg commented Dec 16, 2019

Fixes #17
Fixes #18

Copy link
Contributor

@tgregg tgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge in the latest changes from master to resolve conflicts and update this branch. Then I'll squash and merge this to master.

@avneet-toor-bq
Copy link
Contributor Author

Please merge in the latest changes from master to resolve conflicts and update this branch. Then I'll squash and merge this to master.

Done.

@tgregg tgregg merged commit 6602b88 into amazon-ion:master Dec 17, 2019
This was referenced Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants