-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create interfaces for IonDotnet.Tree #30
Merged
tgregg
merged 12 commits into
amazon-ion:master
from
avneet-toor-bq:dotnet-tree-changes
Dec 17, 2019
Merged
Create interfaces for IonDotnet.Tree #30
tgregg
merged 12 commits into
amazon-ion:master
from
avneet-toor-bq:dotnet-tree-changes
Dec 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgregg
reviewed
Dec 16, 2019
…thod in IValueFactory.
tgregg
approved these changes
Dec 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge in the latest changes from master
to resolve conflicts and update this branch. Then I'll squash and merge this to master
.
Done. |
tgregg
approved these changes
Dec 17, 2019
This was referenced Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #17 #18
Description of changes:
IonXXX
types inIonDotnet.Tree
packageIonXXX
types put inValueFactory.cs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.