Updates release script #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
reviewed
Jul 20, 2023
popematt
reviewed
Jul 20, 2023
popematt
reviewed
Jul 20, 2023
.github/workflows/release.yml
Outdated
Comment on lines
55
to
56
| permissions: | ||
| checks: write |
There was a problem hiding this comment.
Definitely don't need checks: write here. Looks like this job failed last time because grunt wasn't installed correctly. https://github.com/amazon-ion/ion-js/actions/runs/4800737685/job/13015905967#step:7:15
There was a problem hiding this comment.
I am not sure about why the grunt command shows not found. In the build script it seems to work fine.
There was a problem hiding this comment.
I think we should probably add run: npm ci before doing run: npm publish to solve installing grunt or any other dependencies which might be needed for publish.
From the github documents on publishing node.js package:
- run: npm ci
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{ GITHUB_TOKEN }}
popematt
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR updates the release script which was broken as per the last release.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.