Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates release script #761

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Updates release script #761

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84da490
Updates release script
desaikd Jul 20, 2023
6b46ecc
adds suggested changes
desaikd Jul 20, 2023
8d99563
adds more suggested changes
desaikd Jul 20, 2023
89c0afb
adds installation step before publishing the package
desaikd Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ jobs:
if: startsWith(github.ref, 'refs/tags/v')
runs-on: ubuntu-latest
needs: build
permissions:
checks: write
popematt marked this conversation as resolved.
Show resolved Hide resolved
contents: write
steps:
- name: set env
run: echo "RELEASE_TAG=${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV
Expand All @@ -49,6 +52,8 @@ jobs:
if: startsWith(github.ref, 'refs/tags/v')
runs-on: ubuntu-latest
needs: build
permissions:
checks: write
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely don't need checks: write here. Looks like this job failed last time because grunt wasn't installed correctly. https://github.com/amazon-ion/ion-js/actions/runs/4800737685/job/13015905967#step:7:15

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about why the grunt command shows not found. In the build script it seems to work fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably add run: npm ci before doing run: npm publish to solve installing grunt or any other dependencies which might be needed for publish.
From the github documents on publishing node.js package:

 - run: npm ci
 - run: npm publish
        env:
          NODE_AUTH_TOKEN: ${{ GITHUB_TOKEN }}

steps:
- name: set env
run: echo "RELEASE_TAG=${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV
Expand All @@ -69,6 +74,10 @@ jobs:
if: startsWith(github.ref, 'refs/tags/v')
runs-on: ubuntu-latest
needs: build
permissions:
checks: write
contents: write
pages: write
desaikd marked this conversation as resolved.
Show resolved Hide resolved
steps:
- name: set env
run: echo "RELEASE_TAG=${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV
Expand Down