Fixes incorrect handling of SID 0 as symbol text #515
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None.
Description of changes:
Option<&str>
and changes SID$0
toNone
rather than"$0"
RawSymbolToken
orRawSymbolTokenRef
rather than forcing all symbols to be converted to text.round_trip_skip_list()
inelement_test_vector.rs
to no longer skip SID 0 test cases.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.