Updates code coverage CI to stable #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes pin to nightly and removes the old `-Zprofile` runs and `grcov` based coverage generation in favor of `-C source-instrumentation` which is in stable. This updates the CI to install `llvm-tools-preview` from `rustup` and install a nice wrapper for running source instrumentation called [`cargo-llvm-cov`][1]. We use this wrapper to generate codecov JSON to get region coverage since LCOV style output from source coverage in Rust/LLVM doesn't output branch coverage. [1]: https://crates.io/crates/cargo-llvm-cov
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 89.34% 83.07% -6.28%
==========================================
Files 84 83 -1
Lines 13284 16126 +2842
Branches 0 16126 +16126
==========================================
+ Hits 11869 13396 +1527
- Misses 1415 1566 +151
- Partials 0 1164 +1164
☔ View full report in Codecov by Sentry. |
popematt
approved these changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change finally gets us to using stable rust to generate our code coverage! Prior to this change, we had to pin to nightly Rust, which was a paper cut whenever that broke for various reasons.
LLVM source coverage in Rust is not perfect (e.g., rust-lang/rust#79649, rust-lang/rust#79417), and Codecov has some of its own issues (e.g., taiki-e/cargo-llvm-cov#255 (comment)), but I believe these to be acceptable compromises to getting off of nightly.
Removes pin to nightly and removes the old
-Zprofileruns andgrcovbased coverage generation in favor of-C source-instrumentationwhich is in stable.This updates the CI to install
llvm-tools-previewfromrustupand install a nice wrapper for running source instrumentation calledcargo-llvm-cov. We use this wrapper to generate codecov JSON to get region coverage since LCOV style output from source coverage in Rust/LLVM doesn't output branch coverage.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.