Fix multiple blocking binary reader issues

[nirosys]

Issue #, if available:

Description of changes:

• Fixes an issue where read_from would read fewer bytes than it was expected to.
• Addded incomplete guard to an annotation consume that could cause an error when the buffer did not have enough data.
• Fixed an issue where bytes read into a NBR were counted twice when determining if all data had been read. This probably wasn't an issue since read_from reads all of the data requested.
• Implements stream completion for non-blocking binary reader.
• Moves Expandable to the raw_reader module now that the binary raw reader is using it.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

Patch coverage: 93.63% and project coverage change: +0.04 🎉

Comparison is base (5e9fc59) 83.21% compared to head (f45cc8b) 83.25%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
+ Coverage   83.21%   83.25%   +0.04%     
==========================================
  Files          86       86              
  Lines       16455    16537      +82     
  Branches    16455    16537      +82     
==========================================
+ Hits        13693    13768      +75     
- Misses       1562     1563       +1     
- Partials     1200     1206       +6     

Impacted Files	Coverage Δ
src/text/non_blocking/raw_text_reader.rs	79.22% <ø> (-0.11%)	⬇️
src/blocking_reader.rs	76.08% <90.32%> (+1.31%)	⬆️
src/binary/non_blocking/binary_buffer.rs	94.08% <92.30%> (-0.09%)	⬇️
src/binary/non_blocking/raw_binary_reader.rs	80.27% <95.00%> (+0.40%)	⬆️
src/raw_reader.rs	79.34% <100.00%> (+1.44%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[zslayton]

The diff looks good! Could you add unit tests that cover the corner cases this addresses?

[nirosys]

The diff looks good! Could you add unit tests that cover the corner cases this addresses?

Absolutely, I'll try to push those up tomorrow.

[nirosys]

Pushed up some unit tests:

read_from reading fewer bytes, and potentially panicking.

Pre-PR:

thread 'binary::non_blocking::binary_buffer::tests::validate_read_from_size' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `11`', src/binary/non_blocking/binary_buffer.rs:821:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test binary::non_blocking::binary_buffer::tests::validate_read_from_size ... FAILED

failures:

failures:
    binary::non_blocking::binary_buffer::tests::validate_read_from_size

Post PR:

test binary::non_blocking::binary_buffer::tests::validate_read_from_size ... ok

Processing annotation bytes leading to panic from BinaryBuffer over-consume.

Pre-PR:

thread 'binary::non_blocking::raw_binary_reader::tests::test_incomplete_annotation_wrapper' panicked at 'assertion failed: num_bytes_to_consume <= self.remaining()', src/binary/non_blocking/binary_buffer.rs:121:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test binary::non_blocking::raw_binary_reader::tests::test_incomplete_annotation_wrapper ... FAILED

failures:

failures:
    binary::non_blocking::raw_binary_reader::tests::test_incomplete_annotation_wrapper

Post PR:

test binary::non_blocking::raw_binary_reader::tests::test_incomplete_annotation_wrapper ... ok

End of Stream implementation in binary reader.

Pre-PR:

thread 'blocking_reader::tests::test_binary_end_of_stream' panicked at 'assertion failed: `(left == right)`
  left: `Value(Bool)`,
 right: `Nothing`', src/blocking_reader.rs:561:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test blocking_reader::tests::test_binary_end_of_stream ... FAILED

failures:

failures:
    blocking_reader::tests::test_binary_end_of_stream

Post-PR:

test blocking_reader::tests::test_binary_end_of_stream ... ok

[zslayton]

Glad to have this fixed, thanks!