Update to partiql-lang-rust 0.4.1 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## pre-update #12 +/- ##
=============================================
- Coverage 0.15% 0.14% -0.01%
=============================================
Files 7 7
Lines 647 669 +22
=============================================
Hits 1 1
- Misses 646 668 +22
☔ View full report in Codecov by Sentry. |
alancai98
approved these changes
May 26, 2023
| partiql-value = "0.4" | ||
| partiql-eval = "0.4" | ||
| partiql-extension-ion = "0.4" | ||
| partiql-extension-ion-functions = "~0.4.1" |
There was a problem hiding this comment.
Should this version be "0.4"?
Suggested change
| partiql-extension-ion-functions = "~0.4.1" | |
| partiql-extension-ion-functions = "0.4." |
There was a problem hiding this comment.
No, requires 0.4.1 or above for this change: partiql/partiql-lang-rust#377
| @@ -62,6 +67,12 @@ tiny-skia = { version ="0.6.*", optional = true } | |||
| strum = { version ="0.24.*", features = ["derive"], optional = true } | |||
| dot-writer = { version = "0.1.*", optional = true } | |||
|
|
|||
| ion-rs = {git="https://github.com/amazon-ion/ion-rust"} | |||
There was a problem hiding this comment.
Is it pointing to the GitHub repo because there's a feature not yet released by ion-rs?
There was a problem hiding this comment.
Yes. In some cases (several of my test cases), the ion reader would fail. All that I've seen are fixed by amazon-ion/ion-rust#552
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.