-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to partiql-lang-rust 0.4.1 #12
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## pre-update #12 +/- ##
=============================================
- Coverage 0.15% 0.14% -0.01%
=============================================
Files 7 7
Lines 647 669 +22
=============================================
Hits 1 1
- Misses 646 668 +22
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to update to v0.4.1. Had a couple questions about some imports. Also, is this PR meant to target pre-update
or main
?
partiql-value = "0.4" | ||
partiql-eval = "0.4" | ||
partiql-extension-ion = "0.4" | ||
partiql-extension-ion-functions = "~0.4.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this version be "0.4"?
partiql-extension-ion-functions = "~0.4.1" | |
partiql-extension-ion-functions = "0.4." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, requires 0.4.1 or above for this change: partiql/partiql-lang-rust#377
@@ -62,6 +67,12 @@ tiny-skia = { version ="0.6.*", optional = true } | |||
strum = { version ="0.24.*", features = ["derive"], optional = true } | |||
dot-writer = { version = "0.1.*", optional = true } | |||
|
|||
ion-rs = {git="https://github.com/amazon-ion/ion-rust"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it pointing to the GitHub repo because there's a feature not yet released by ion-rs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. In some cases (several of my test cases), the ion reader would fail. All that I've seen are fixed by amazon-ion/ion-rust#552
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.