Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes SymbolTable and Catalog from the public API #602

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

zslayton
Copy link
Contributor

Removes the SymbolTable and Catalog/MapCatalog types from the public API. Also marks any mutating methods on SymbolTable as pub(crate); users do not need to modify the symbol table.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ef641f4) 82.45% compared to head (95717a2) 82.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #602   +/-   ##
=======================================
  Coverage   82.45%   82.45%           
=======================================
  Files         111      111           
  Lines       20029    20032    +3     
  Branches    20029    20032    +3     
=======================================
+ Hits        16515    16518    +3     
  Misses       1896     1896           
  Partials     1618     1618           
Impacted Files Coverage Δ
src/binary/binary_writer.rs 64.67% <ø> (ø)
src/lib.rs 0.00% <ø> (ø)
src/system_reader.rs 69.37% <ø> (ø)
src/text/text_writer.rs 75.65% <ø> (ø)
src/symbol_table.rs 91.66% <100.00%> (+0.36%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zslayton zslayton merged commit 202bd2b into main Jul 18, 2023
18 checks passed
@zslayton zslayton deleted the hide-symtab branch July 18, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants