Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: various changes to versioning and fix for strict confinement #252

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

soumyaDghosh
Copy link
Contributor

@soumyaDghosh soumyaDghosh commented Jun 28, 2024

  1. set the version from Cargo.toml file using tomlq provided by the jq package
  2. added the bc binary as needed by amber

snap/snapcraft.yaml Show resolved Hide resolved
snap/snapcraft.yaml Show resolved Hide resolved
@b1ek
Copy link
Member

b1ek commented Jun 28, 2024

please, name the PR as per what it does or should do. also include a detailed but dense description of what it does, caveats, etc

@soumyaDghosh
Copy link
Contributor Author

please, name the PR as per what it does or should do. also include a detailed but dense description of what it does, caveats, etc

Yeah I would have done, but actually I have got some medical emergency but this was also important, so took the shortcut, sorry for that.

@b1ek
Copy link
Member

b1ek commented Jun 28, 2024

I have got some medical emergency but this was also important

i dont mean to sound rude, but thats irrelevant. either take time to write a sensible description, or postpone it, or do not write it at all (unless the title sufficiently describes the whole thing)

i hope you are alright <3

@soumyaDghosh soumyaDghosh changed the title snap: set the version from the cargo file snap: various changes to versioning and fix for strict confinement Jun 28, 2024
@soumyaDghosh soumyaDghosh requested a review from b1ek June 28, 2024 13:37
@soumyaDghosh
Copy link
Contributor Author

@Ph0enixKM please review this

@b1ek b1ek requested review from Mte90 and Ph0enixKM July 1, 2024 09:03
@Mte90 Mte90 merged commit 67d6382 into amber-lang:master Jul 1, 2024
2 checks passed
Mte90 pushed a commit to Mte90/Amber that referenced this pull request Jul 3, 2024
…mber-lang#252)

* snap: set the version from the cargo file

* snap: add `bc` and fix command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants