Bug/1106

[sebastianconcept]

No description provided.

[ghost]

Please rebase to master without d06c091 and 451faf8 from Jul. How did you get those there?
Also, 2931ed4 seems to repeat the same changes which are already in 5cecd2d. Did you erase them with the c9f709f merge?

[ghost]

There is one more formal thing: please do not create branch names with slashes. They clash with remote naming like origin/master or upstream/grunt-devel-fix or so. People most often use dashes as separators in branch names.

[sebastianconcept]

I think old stuff got in the middle and the merge bring that up

Will take a look

[sebastianconcept]

What's the convention here for branch naming?

[ghost]

There is no formal convention. I just name my ones after the feature they implement, dash-separated, or use gh-nnn for github issue nnn. But I saw no one using slashes, yet (maybe it wasn't even possible in previous git versions?).

[sebastianconcept]

The slash in the branch name is typically used by tools to show them grouped as folders. I know git flow introduces it to create categories: bug, feature and hotfix.

I'm fine evading the use of slashes in future branches

[ghost]

Ah. Didn't know. Ok. Maybe it got used more often when it's there - maybe just I missed the newest trends. Time will tell.

Sebastian Sastre wrote:

The slash in the branch name is typically used by tools to show them
grouped as folders. I know |git flow| introduces it to create
categories: bug, feature and hotfix.

I'm fine evading the use of slashes in future branches

—
Reply to this email directly or view it on GitHub
#1108 (comment).