Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move IDE, Example, Benchfib and conf into amber-attic #1126

Merged
2 commits merged into from Jan 8, 2015
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jan 8, 2015

They are not part of the core, they should not be under amber_core.
Moreover, they bring jquery-ui and codemirror as deps,
which amber in itself does not need. Later amber-attic
can have its own repo and these deps can be moved there.

@ghost ghost added the enhancement label Jan 8, 2015
@ghost ghost added this to the 0.15.0 milestone Jan 8, 2015
They are not part of the core, they should not be under amber_core.
Moreover, they bring jquery-ui and codemirror as deps,
which amber in itself does not need. Later amber-attic
can have its own repo and these deps can be moved there.
@ghost ghost force-pushed the move-things-to-attic branch from 9c9c863 to 0604a2c Compare January 8, 2015 15:32
@hhzl
Copy link
Member

hhzl commented Jan 8, 2015

I think it is a good move.

ghost pushed a commit that referenced this pull request Jan 8, 2015
move IDE, Example, Benchfib and conf into amber-attic
@ghost ghost merged commit 8b9eac0 into master Jan 8, 2015
@hhzl
Copy link
Member

hhzl commented Jan 9, 2015

Great!

@ghost ghost modified the milestones: 0.15.0, 0.14.3 Jan 19, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant