Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model: add -m option to change model: granite, crecto or jennifer #54

Closed
elorest opened this issue May 19, 2017 · 7 comments
Closed

Model: add -m option to change model: granite, crecto or jennifer #54

elorest opened this issue May 19, 2017 · 7 comments

Comments

@elorest
Copy link
Member

elorest commented May 19, 2017

Implemented in a way that separates the behavior that we want to express (entities) from the persistence layer (repositories and database). This design helps keep the interface of our objects small and therefore keeps them fast and reusable.

@elorest
Copy link
Member Author

elorest commented May 19, 2017

Perhaps we should remain ORM/REPO agnostic and add generators for different libraries?

@eliasjpr
Copy link
Contributor

eliasjpr commented May 20, 2017

At the moment, I think this is the best we can do until we discuss technical details.

@jwoertink
Copy link

It's actually pretty interesting that there's no built in model. This doesn't have to be another MVC. Having it handle routes, controllers, views, middleware, etc.. is quite a bit already. Being able to just plug in your own way of handling models and other business logic type stuff would be nice. Maybe there could be a separate shard for a "amber" type way of handling this stuff, but by default not in the amber shard.

@eliasjpr eliasjpr added this to Pending in Framework 2018 Jun 7, 2017
@oz
Copy link

oz commented Jul 31, 2017

That being said, seeing how the router is inspired from Phoenix, I though I'd find Crecto in there too. As long as it is easy to swap parts, I think that an "all-in-one" opinionated model makes sense (even if I had a different opinion on the ORM 😉).

@eliasjpr
Copy link
Contributor

eliasjpr commented Aug 1, 2017

@oz We are considering to support Crecto for a Repo pattern type of models and Granite/Jennifer for Active Record Pattern with generators we still thinking about this one

@drujensen drujensen changed the title Model Model: add flag -m to new that allows you to choose granite, crecto or jennifer Sep 11, 2017
@drujensen drujensen changed the title Model: add flag -m to new that allows you to choose granite, crecto or jennifer Model: add -m option to change model: granite, crecto or jennifer Sep 11, 2017
@drujensen
Copy link
Member

Here is the example app created by @fridgerator for using crecto with amber:
https://github.com/fridgerator/amber_crecto_example

drujensen added a commit that referenced this issue Oct 3, 2017
drujensen added a commit that referenced this issue Oct 4, 2017
* #54 support crecto

* minor bug fixes

* float64

* fix auth migration

* bug fixes
@drujensen
Copy link
Member

I am going to close this since we support granite and crecto. We can open a new ticket if someone wants to add jennifer.

marksiemers pushed a commit to marksiemers/amber that referenced this issue Oct 28, 2017
* amberframework#54 support crecto

* minor bug fixes

* float64

* fix auth migration

* bug fixes
elorest pushed a commit that referenced this issue Nov 17, 2017
* #54 support crecto

* minor bug fixes

* float64

* fix auth migration

* bug fixes
@faustargz faustargz moved this from Backlog to In Development in Framework 2018 Mar 17, 2018
@faustargz faustargz moved this from In Development to Completed in Framework 2018 Mar 17, 2018
@faustargz faustargz added this to Done in Framework 2018 May 5, 2018
@faustargz faustargz removed this from Done in Framework 2018 Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

7 participants