Quick fix for auth template, see issue #1174 #1181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR is meant to be a quick fix for issue #1174
This isn't meant to be a permanent change. You can read my reasoning in the issue.
Alternate Designs
Any alternates would have to be in either Granite or Amber Router but i believe it's a granite issue as
Param#validate!successfully returns the proper hash.Benefits
Users of amberframework have access to a working auth template. Currently, the auth template builds but fails to actually work.
Possible Drawbacks
No drawbacks that i am aware of, minus being ugly. I would love if someone more experienced can let me know if i am wrong. But we still call
Params#validate!to ensure the params are safe.