Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add '--minimal' option for app generation #1206

Merged
merged 5 commits into from Jun 8, 2020
Merged

Add '--minimal' option for app generation #1206

merged 5 commits into from Jun 8, 2020

Conversation

OpakAlex
Copy link
Contributor

@OpakAlex OpakAlex commented Jun 7, 2020 •
edited

Description of the Change

Add --minimal option for app generation. This will disable npm dependencies.

#1205

Benefits

Easy to create new API apps

Possible Drawbacks

Not sure

drujensen
drujensen previously approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@drujensen drujensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

src/amber/cli/generators/app.cr Show resolved Hide resolved
@OpakAlex
Copy link
Contributor Author

OpakAlex commented Jun 8, 2020

@drujensen can you recheck pls?

@OpakAlex OpakAlex requested a review from drujensen June 8, 2020 06:35
@OpakAlex
Copy link
Contributor Author

OpakAlex commented Jun 8, 2020

Thanks. How is merging happens here? You have some releases and merge depends on it?

@drujensen drujensen merged commit 8c069f5 into amberframework:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drujensen drujensen drujensen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OpakAlex @drujensen