fix links on homepage #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasjpr
requested changes
Sep 12, 2017
There was a problem hiding this comment.
Change the docs links to point to https://docs.amberframework.org
| <a class="list-group-item" src="https://amber-crystal.gitbooks.io/amber/content/getting-started.html">Getting Started with Amber Framework</a> | ||
| <a class="list-group-item" src="https://github.com/veelenga/awesome-crystal">List of Awesome Crystal projects and shards</a> | ||
| <a class="list-group-item" src="https://crystalshards.xyz">What's hot in Crystal right now</a> | ||
| <a class="list-group-item list-group-item-action" target="_blank" href="https://amber-crystal.gitbooks.io/amber/content/getting-started.html">Getting Started with Amber Framework</a> |
There was a problem hiding this comment.
Change this to https://docs.amberframework.org
| a.list-group-item src="https://amber-crystal.gitbooks.io/amber/content/getting-started.html" Getting Started with Amber Framework | ||
| a.list-group-item src="https://github.com/veelenga/awesome-crystal" List of Awesome Crystal projects and shards | ||
| a.list-group-item src="https://crystalshards.xyz" What's hot in Crystal right now | ||
| a.list-group-item.list-group-item-action target="_blank" href="https://amber-crystal.gitbooks.io/amber/content/getting-started.html" Getting Started with Amber Framework |
Closed
faustinoaq
approved these changes
Sep 12, 2017
eliasjpr
approved these changes
Sep 13, 2017
marksiemers
pushed a commit
to marksiemers/amber
that referenced
this pull request
Oct 28, 2017
* fix links on homepage * update links
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
* fix links on homepage * update links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The links on the generated homepage did not work. This also add a target="_blank" so it will open a new tab.
Alternate Designs
Please provide feedback on other resources and links we should provide on this page.