Lock shard.yml Amber version to version of cli that generated it. #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasjpr
approved these changes
Oct 13, 2017
fridgerator
reviewed
Oct 13, 2017
| @@ -18,6 +18,8 @@ targets: | |||
| dependencies: | |||
| amber: | |||
| github: amberframework/amber | |||
| version: <%= Amber::VERSION %> | |||
| #branch: master | |||
There was a problem hiding this comment.
did you mean to leave this here?
fridgerator
approved these changes
Oct 13, 2017
marksiemers
pushed a commit
to marksiemers/amber
that referenced
this pull request
Oct 28, 2017
…berframework#304) * defaults amber version to the same version as the cli * changed spec to test this scenario
elorest
added a commit
that referenced
this pull request
Nov 17, 2017
* defaults amber version to the same version as the cli * changed spec to test this scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Locks Amber version in
shard.ymltoAmber::VERSIONof CLI that generated it.