Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on html code #314

Merged
merged 2 commits into from Oct 25, 2017
Merged

Fix typo on html code #314

merged 2 commits into from Oct 25, 2017

Conversation

faustinoaq
Copy link
Contributor

Description of the Change

  • Replace ? by >
  • Close tag correctly

Discovered by @mixflame :

on default setup, views/home/index.cr has a bug in the template, unclosed tag

Alternate Designs

Nil

Benefits

Nil

Possible Drawbacks

Nil

- Replace ? by >
- Close tag correctly
@faustinoaq
Copy link
Contributor Author

Why is Travis still checking this ? 😅

Copy link
Member

@elorest elorest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@faustinoaq
Copy link
Contributor Author

Seems travis is ok:

screenshot_20171024_075140

But Why I still see this?:

screenshot_20171024_075217

@elorest
Copy link
Member

elorest commented Oct 24, 2017 via email

@faustinoaq
Copy link
Contributor Author

Just repush it. Travis gets stuck sometimes.

@elorest Done! 👍

@eliasjpr eliasjpr merged commit 27de213 into amberframework:master Oct 25, 2017
@faustinoaq faustinoaq deleted the patch-1 branch October 25, 2017 01:24
marksiemers pushed a commit to marksiemers/amber that referenced this pull request Oct 28, 2017
- Replace ? by >
- Close tag correctly
elorest pushed a commit that referenced this pull request Nov 17, 2017
- Replace ? by >
- Close tag correctly
@faustinoaq faustinoaq added this to Done in Framework 2018 May 5, 2018
@faustinoaq faustinoaq removed this from Done in Framework 2018 Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants