New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo on html code #314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace ? by > - Close tag correctly
eliasjpr
approved these changes
Oct 18, 2017
fridgerator
approved these changes
Oct 19, 2017
Why is Travis still checking this ? 😅 |
elorest
approved these changes
Oct 23, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just repush it. Travis gets stuck sometimes.
…On Oct 24, 2017 6:53 AM, "Faustino Aguilar" ***@***.***> wrote:
Seems travis is ok:
[image: screenshot_20171024_075140]
<https://user-images.githubusercontent.com/3067335/31943988-2cb4d116-b890-11e7-9729-d3a161857db1.png>
But Why I still see this?:
[image: screenshot_20171024_075217]
<https://user-images.githubusercontent.com/3067335/31944014-43048056-b890-11e7-851c-e59e5d958371.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#314 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHmpKpqU1KD8fOdfKv74tsiXoE0GSOuks5svd3YgaJpZM4P-UmD>
.
|
@elorest Done! 👍 |
marksiemers
pushed a commit
to marksiemers/amber
that referenced
this pull request
Oct 28, 2017
- Replace ? by > - Close tag correctly
This was referenced Nov 12, 2017
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
- Replace ? by > - Close tag correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Discovered by @mixflame :
Alternate Designs
Nil
Benefits
Nil
Possible Drawbacks
Nil