Fix missing require for task runner #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Amber is not compiling on master because of missing requires. This adds require to the correct places. Amber compiles successfully after.
drujensen
approved these changes
Oct 28, 2017
|
@elorest I'm going to merge to get master fixed. If you have feedback, still provide it. |
|
^ So I left that message above. Not used to there being someone else logged into github on my livingroom computer. |
marksiemers
pushed a commit
to marksiemers/amber
that referenced
this pull request
Oct 28, 2017
Currently Amber is not compiling on master because of missing requires. This adds require to the correct places. Amber compiles successfully after.
This was referenced Nov 12, 2017
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
Currently Amber is not compiling on master because of missing requires. This adds require to the correct places. Amber compiles successfully after.
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
Currently Amber is not compiling on master because of missing requires. This adds require to the correct places. Amber compiles successfully after. Former-commit-id: e2d7a12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Currently Amber is not compiling on master because of missing requires.
This adds require to the correct places.
Amber compiles successfully after.
Alternate Designs
Benefits
Possible Drawbacks