Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format comments using JSDoc pattern #338

Merged
merged 2 commits into from Oct 31, 2017
Merged

Format comments using JSDoc pattern #338

merged 2 commits into from Oct 31, 2017

Conversation

faustinoaq
Copy link
Contributor

Description of the Change

Apply formatting to JavaScript comments following JSDoc pattern

Alternate Designs

No

Benefits

Best support by editors and JS tools.

Before:

screenshot_20171029_095252

After:

screenshot_20171029_095316

Possible Drawbacks

No

/cc @fridgerator @drujensen

Copy link
Member

@elorest elorest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@eliasjpr eliasjpr merged commit bb337da into amberframework:master Oct 31, 2017
elorest pushed a commit that referenced this pull request Nov 17, 2017
elorest pushed a commit that referenced this pull request Nov 17, 2017
@faustinoaq faustinoaq added this to Done in Framework 2018 May 5, 2018
@faustinoaq faustinoaq removed this from Done in Framework 2018 Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants