Use table name as part of database index name (#336) #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I refactored to get the sql generation in one place (for the I can also refactor for the rest of the migration SQL generation in the PR if wanted. LMK |
|
I have a separate branch and PR (in my fork) for the aforementioned refactor: https://github.com/marksiemers/amber/pull/1/files It can be a separate PR, or I can merge so it goes with this change. |
|
@drujensen - Do we want the additional refactor that is in my fork? Or should that be a seperate PR? |
|
wow, nice cleanup work. It seems somewhat related so go ahead and include it. It doesn't look too big. |
This was referenced Nov 12, 2017
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
* Write tests for CREATE INDEX line in migrations template (#336) * Implement including table name in CREATE INDEX line in migrations template * Refactor generating CREATE INDEX sql statements for reference fields (#336) * Refactor generating migrations * Refactor tests for migration cli templates Former-commit-id: fc551c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes #336
Alternate Designs
The lines that fix this issue exist in two ECR files. The code can likely be refactored into the Migration template class.
Benefits
Fixes #336
Possible Drawbacks
None known.