Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge docker files #350

Merged
merged 5 commits into from Nov 4, 2017
Merged

merge docker files #350

merged 5 commits into from Nov 4, 2017

Conversation

drujensen
Copy link
Member

@drujensen drujensen commented Nov 1, 2017

Description of the Change

This merges the docker files in the root and spec folders into one set in the root folder so we don't maintain 2 sets.

Alternate Designs

maintain 2 sets

Benefits

only need to maintain 1 set

Possible Drawbacks

none that i can think of

@faustinoaq
Copy link
Contributor

Do we should merge docker files on app template too?

Dockerfile.ecr and docker-compose.yml.ecr

https://github.com/amberframework/amber/tree/master/src/amber/cli/templates/app

@drujensen
Copy link
Member Author

@elorest are you good with this? would like to merge.

@faustinoaq
Copy link
Contributor

@drujensen Do you think we should merge Dockerfile.ecr and docker-compose.yml.ecr on app template too ? https://github.com/amberframework/amber/tree/master/src/amber/cli/templates/app

Copy link
Member

@elorest elorest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eliasjpr eliasjpr merged commit c4e4b92 into master Nov 4, 2017
@eliasjpr eliasjpr deleted the dj/merge-docker-files branch November 4, 2017 10:51
elorest pushed a commit that referenced this pull request Nov 17, 2017
elorest pushed a commit that referenced this pull request Nov 17, 2017
@faustinoaq faustinoaq added this to Done in Framework 2018 May 5, 2018
@faustinoaq faustinoaq removed this from Done in Framework 2018 Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants