New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge docker files #350
merge docker files #350
Conversation
Do we should merge docker files on app template too?
https://github.com/amberframework/amber/tree/master/src/amber/cli/templates/app |
@elorest are you good with this? would like to merge. |
@drujensen Do you think we should merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description of the Change
This merges the docker files in the root and spec folders into one set in the root folder so we don't maintain 2 sets.
Alternate Designs
maintain 2 sets
Benefits
only need to maintain 1 set
Possible Drawbacks
none that i can think of