cli: implement db create/drop for sqlite3
#351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I can reproduce this, A workaround is using |
faustinoaq
approved these changes
Nov 2, 2017
eliasjpr
requested changes
Nov 2, 2017
|
@nathanj Yeah, please add some test for |
|
I added a test to |
|
@nathanj you can add the specs in |
When running `amber db create` for an sqlite3 database, amber displays the error: could not determine database name This can be confusing to the user who doesn't know that `amber db create` does not need to be run for sqlite3 databases. Display a friendlier message. Also implement `amber db drop` to delete the database.
|
Moved the tests and made them a little more spec-like I think (this is my first time using spec). |
|
@nathanj Thank you we were just talking about your PR 🎉 |
eliasjpr
approved these changes
Nov 8, 2017
This was referenced Nov 12, 2017
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
When running `amber db create` for an sqlite3 database, amber displays the error: could not determine database name This can be confusing to the user who doesn't know that `amber db create` does not need to be run for sqlite3 databases. Display a friendlier message. Also implement `amber db drop` to delete the database.
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
When running `amber db create` for an sqlite3 database, amber displays the error: could not determine database name This can be confusing to the user who doesn't know that `amber db create` does not need to be run for sqlite3 databases. Display a friendlier message. Also implement `amber db drop` to delete the database. Former-commit-id: 3253ec9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
amber db createfor an sqlite3 database, amber displaysthe error:
could not determine database name
This can be confusing to the user who doesn't know that
amber db createdoes not need to be run for sqlite3 databases. Display afriendlier message.
Also implement
amber db dropto delete the database.