Organizes Controllers Helper Methods #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moves redirect into the Helpers subdirectory in controller - Updates require path - Renames Helper::Tags to Helpers::CSRF
faustinoaq
approved these changes
Nov 3, 2017
elorest
reviewed
Nov 3, 2017
| @@ -1,5 +1,5 @@ | |||
| module Amber::Controller::Helpers | |||
| module Tag | |||
| module CSRF | |||
There was a problem hiding this comment.
Probably name the file csrf.cr as well if you're changing the name of the module.
elorest
approved these changes
Nov 3, 2017
This was referenced Nov 12, 2017
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
* Organizes Controllers Helper Methods - Moves redirect into the Helpers subdirectory in controller - Updates require path - Renames Helper::Tags to Helpers::CSRF * Rename tags.cr to csrf.cr * Remove include RedirectMethods
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
* Organizes Controllers Helper Methods - Moves redirect into the Helpers subdirectory in controller - Updates require path - Renames Helper::Tags to Helpers::CSRF * Rename tags.cr to csrf.cr * Remove include RedirectMethods Former-commit-id: d5f143d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Alternate Designs
Benefits
Possible Drawbacks