[Controller] Adds Route Helper Methods to Controller #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> As a developer I want to have access to the current matched route information such as the Action, Controller, Resource and Scope accessed. This adds a Route helper file - Includes the following methods route_action, route_controller, route_resource, route_scope in the controller ### Alternate Design I thought of using a different name such as action_name, controller_name but it seemed more explicit to have `route_` prefix to hint the user where is this information is coming from.
eliasjpr
requested review from
a team,
drujensen,
marksiemers,
faustinoaq and
veelenga
and removed request for
a team
faustinoaq
approved these changes
Nov 5, 2017
marksiemers
suggested changes
Nov 5, 2017
| end | ||
|
|
||
| def controller_name | ||
| self.class.name.gsub(/Controller/i, "") |
There was a problem hiding this comment.
For this regex, I would anchor to the end. And does the i make it case-insensitive, is that necessary?
There was a problem hiding this comment.
Would people want the controller name downcased?
There was a problem hiding this comment.
Yeah, I think we should use /Controller$/
There was a problem hiding this comment.
You guys are correct I will also fix the regex. I looked at the rails implementation
https://apidock.com/rails/ActionController/Metal/controller_name/class
There was a problem hiding this comment.
Use sub instead of gsub since we only want to replace once.
spec/amber/controller/base_spec.cr
Outdated
| controller.responds_to?(:route_action).should eq true | ||
| controller.responds_to?(:route_resource).should eq true | ||
| controller.responds_to?(:route_scope).should eq true | ||
| controller.responds_to?(:route_controller).should eq true |
There was a problem hiding this comment.
Do all of these need to be prefixed with route_?
There was a problem hiding this comment.
I prefixed to avoid name collisions with methods define by the user. I am open to suggestions
eliasjpr
changed the title
marksiemers
approved these changes
Nov 8, 2017
This was referenced Nov 12, 2017
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
* Adds Route Helper Methods to Controller > As a developer I want to have access to the current matched route information such as the Action, Controller, Resource and Scope accessed. This adds a Route helper file - Includes the following methods route_action, route_controller, route_resource, route_scope in the controller ### Alternate Design I thought of using a different name such as action_name, controller_name but it seemed more explicit to have `route_` prefix to hint the user where is this information is coming from. * fixup! Adds Route Helper Methods to Controller
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
* Adds Route Helper Methods to Controller > As a developer I want to have access to the current matched route information such as the Action, Controller, Resource and Scope accessed. This adds a Route helper file - Includes the following methods route_action, route_controller, route_resource, route_scope in the controller ### Alternate Design I thought of using a different name such as action_name, controller_name but it seemed more explicit to have `route_` prefix to hint the user where is this information is coming from. * fixup! Adds Route Helper Methods to Controller Former-commit-id: 3df8c1e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Route helper file
route_resource, route_scope in the controller
Alternate Design
I thought of using a different name such as action_name, controller_name
but it seemed more explicit to have
route_prefix to hint the user where isthis information is coming from.