Improved settings and fixed tests #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effecting it's state randomly. Also conforms to best practices.
elorest
requested review from
eliasjpr,
drujensen,
fridgerator and
faustinoaq
faustinoaq
approved these changes
Nov 6, 2017
marksiemers
approved these changes
Nov 7, 2017
There was a problem hiding this comment.
lgtm.
I think overall, we can continue to make an effort to have better structure the tests (files and actual tests).
I ran into a similar issue where it was a challenge to effectively isolate tests.
If there are any before_each or after_each we should try to get rid of them. They are unscoped - it is before_each test in the entire test suite.
| @@ -37,6 +36,7 @@ describe Amber do | |||
| end | |||
There was a problem hiding this comment.
It seems like this should be a test for Amber::Settings rather than Amber::Server.configure
eliasjpr
approved these changes
Nov 7, 2017
This was referenced Nov 12, 2017
elorest
added a commit
that referenced
this pull request
Nov 17, 2017
* Fixed session so that it could be tested without previous tests effecting it's state randomly. Also conforms to best practices. * resolved logging level settings with instance variables * added settings to configure with block since it's probably clear than configure. * added requested test change
elorest
added a commit
that referenced
this pull request
Nov 17, 2017
* Fixed session so that it could be tested without previous tests effecting it's state randomly. Also conforms to best practices. * resolved logging level settings with instance variables * added settings to configure with block since it's probably clear than configure. * added requested test change Former-commit-id: 232ab29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixed Settings so that it is initialized. This allows it to be tested without previous tests effecting it's state randomly. Also conforms to best practices.
Benefits
Allows for better tests. A few of the settings tests had to be commented out because settings were being overwritten by previous tests. It also makes more sense to instantiate settings when server is started instead of having a preexisting pseudo singleton.
Possible Drawbacks
None.