Trying again to get the tests to pass predictably on linux. #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2017
elorest
added a commit
that referenced
this pull request
Nov 17, 2017
* Got travis tests to pass every time. Ended up being an issue of timestamp resolution on files for linux. * trying again 😢 * Update environment_loader.cr * changed timestamp to milliseconds * one last push to make sure travis still passes 4 times in a row
elorest
added a commit
that referenced
this pull request
Nov 17, 2017
* Got travis tests to pass every time. Ended up being an issue of timestamp resolution on files for linux. * trying again 😢 * Update environment_loader.cr * changed timestamp to milliseconds * one last push to make sure travis still passes 4 times in a row Former-commit-id: b808127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This is the exec PR, that has already been merged and then reverted. I has this really annoying issue where the specs pass every time on osx. But on linux they only pass sometimes and it's not really clear why.
Continuing that for day 2. 😢