Applies crystal tool format to master branch #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridgerator
previously approved these changes
May 7, 2017
bew
previously requested changes
May 7, 2017
src/amber/controller/render.cr
Outdated
| @@ -1,21 +1,21 @@ | |||
| module Amber::Controller | |||
| module Render | |||
| macro render_both(filename, layout) | |||
| macro render_both(filename, layout) | |||
| content = render_template("{{filename.id}}") | |||
There was a problem hiding this comment.
Macros needs manual indentation
src/amber/controller/render.cr
Outdated
| # helper to render a template. The view name is relative to `src/views` directory. | ||
| macro render_template(filename, *args) | ||
| # helper to render a template. The view name is relative to `src/views` directory. | ||
| macro render_template(filename, *args) | ||
| {% if filename.id.split("/").size > 2 %} |
There was a problem hiding this comment.
Macros needs manual indentation
src/amber/controller/render.cr
Outdated
| {% if filename.id.split("/").size > 2 %} | ||
| Kilt.render("{{filename.id}}", {{*args}}) | ||
| {% else %} | ||
| Kilt.render("src/views/{{filename.id}}", {{*args}}) | ||
| {% end %} | ||
| end | ||
|
|
||
| macro render(filename, layout = "layouts/application.slang", path = "src/views", folder = __FILE__) | ||
| macro render(filename, layout = "layouts/application.slang", path = "src/views", folder = __FILE__) | ||
| render_both "#{{{path}}}/#{{{folder.split("/").last.gsub(/\_controller\.cr|\.cr/, "")}}}/#{{{filename}}}", "#{{{path}}}/#{{{layout}}}" |
There was a problem hiding this comment.
Macros needs manual indentation
eliasjpr
force-pushed
the
elias/ch45/apply-tool-format-to-master
branch
from
33d35d4
to
666e248
Compare
|
Please review |
fridgerator
previously approved these changes
May 9, 2017
Issue: https://app.clubhouse.io/amber/story/45/apply-tool-format-to-master Some files needed to be formatted by the crystal tool format * Applied crystal tool formats and formatted a couple of files. * Cleans up the formatting in static_controller, render, router dsl, and route class.
eliasjpr
force-pushed
the
elias/ch45/apply-tool-format-to-master
branch
from
22b5866
to
c2091ed
Compare
elorest
added a commit
that referenced
this pull request
Aug 26, 2017
* fixed DockerFile and cleaned up flash in controller template * fixed ecr rendering and bumped * removed sidekiq from shard template and index action from appliction controller * fixed specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies crystal tool format to master branch
Issue: https://app.clubhouse.io/amber/story/45/apply-tool-format-to-master
Some files needed to be formatted by the crystal tool format
Applied crystal tool formats and formatted a couple of files.
Cleans up the formatting in static_controller, render, router dsl, and
route class.