Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PORT environment variable #428

Closed
wants to merge 3 commits into from
Closed

Conversation

faustinoaq
Copy link
Contributor

Description of the Change

Add support for PORT environment variable, 3000 is used by default.

port: (ENV["PORT"]? || 3000).to_i

Alternate Designs

No

Benefits

Possible Drawbacks

No, if PORT isn't defined port 3000 is used

@faustinoaq
Copy link
Contributor Author

I just realize this PR isn't needed, because now we are using config/application.cr to overwrite environment files, so we just need to fix PORT documentation here (Currently this has a comment in wrong place, see: settings.process_count vs settings.port )

@elorest
Copy link
Member

elorest commented Dec 2, 2017

This was removed recently by @eliasjpr as env.yml's no longer support dynamic code. I'll submit a PR that fixes this now.

@faustinoaq
Copy link
Contributor Author

@elorest Yeah, I was using amber v0.3.6 so I didn't notice this change

I think avoiding dynamic code in yaml files is ok, let me close this 👍

@faustinoaq faustinoaq closed this Dec 2, 2017
@faustinoaq faustinoaq deleted the support-port-env branch December 2, 2017 00:24
@elorest
Copy link
Member

elorest commented Dec 2, 2017

#429

Please review this!

@eliasjpr eliasjpr added this to the 0.5.0 - Features & Bugfixes milestone Dec 22, 2017
@faustinoaq faustinoaq added this to Done in Framework 2018 May 5, 2018
@faustinoaq faustinoaq removed this from Done in Framework 2018 Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants