CLI exceptions show up as readable return values instead of backtrace. #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elorest
requested review from
drujensen,
marksiemers,
eliasjpr,
fridgerator and
faustinoaq
eliasjpr
approved these changes
Dec 9, 2017
| @@ -89,7 +87,7 @@ module Amber::CLI | |||
| Micrate::DB.connection_url = url.gsub(path, "/#{uri.scheme}") | |||
| return path.gsub("/", "") | |||
| else | |||
| raise "could not determine database name" | |||
| raise "Could not determine database name" | |||
There was a problem hiding this comment.
This is within the scope of the main rescue in run. Raising here is more object oriented as exiting is a way that we handle exceptions, not a replacement for exceptions.
| @@ -19,6 +19,10 @@ module Amber::CLI | |||
| encrypted_file = "config/environments/.#{env}.enc" | |||
| unencrypted_file = "config/environments/#{env}.yml" | |||
|
|
|||
| unless File.exists?(unencrypted_file) || File.exists?(encrypted_file) | |||
| raise Exceptions::Environment.new("./config/environments/", env) | |||
There was a problem hiding this comment.
Also covered by existing rescue block. This is necessary for consistent messages.
Again exiting isn't supposed to replace exceptions just handle them in a prettier way for the CLI.
faustinoaq
approved these changes
Dec 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Makes error messages look better by using CLI
exit!command.