New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert router's define_action macro to private #524

Merged

drujensen merged 1 commit into amberframework:master from docelic:set-define_action-macro-private

Jan 14, 2018

Contributor

docelic commented Jan 14, 2018

Convert router's define_action macro to private.

There does not appear to be a reason why this would be
called outside of where it currently is, and can be private.


          Convert router's define_action macro to private

d6de883

drujensen approved these changes

View reviewed changes

Member

drujensen left a comment

lgtm

eliasjpr approved these changes

View reviewed changes

drujensen merged commit 3e605a8 into amberframework:master

faustinoaq added this to Done in Framework 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment