Fix spelling of view templates for newly generated app #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update wording to proper English grammar. It's only a small change but adds to the overall polish of this already great framework. Will propose an equivalent change to the `index.ecr.ecr` template.
Parallel to same wording change applied to `index.slang.ecr`
nicbet
changed the title
eliasjpr
approved these changes
Jan 14, 2018
faustinoaq
approved these changes
Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Changed wording of the view templates
index.ecr.ecrindex.slang.ecrto fix a typo and modify to proper English grammar.
Changed welcome sentence from
Thank you for trying out the Amber Framework. We are working hard to provide a super fast and reliable framework that provides all the productivity tools you are used too but not sacrificing the speed.to
Thank you for trying out the Amber Framework. We are working hard to provide a super fast and reliable framework that provides all the productivity tools you are used to without sacrificing the speed.Alternate Designs
Not Applicable.
Benefits
This may only be a small wording change but it adds to the overall polish of the already great framework. The first page users see in a newly generated app should probably not contain spelling mistakes.
Possible Drawbacks
Not Applicable