Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logger] Use logger built in level methods #533

Merged
merged 1 commit into from Jan 15, 2018
Merged

Conversation

eliasjpr
Copy link
Contributor

The logger currently has a custom puts method that is not logging
correctly the severity.

This removes the additional method and uses the level methods instead.

@eliasjpr eliasjpr requested review from faustinoaq and a team January 15, 2018 02:01
The logger currently has a custom `puts` method that is not logging
correctly the severity.

This removes the additional method and uses the level methods instead.
Copy link
Member

@drujensen drujensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eliasjpr eliasjpr merged commit 084e0f1 into master Jan 15, 2018
@eliasjpr eliasjpr deleted the ep/fixes-logger-ouput branch January 15, 2018 14:54
@faustinoaq faustinoaq added this to Done in Framework 2018 May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants