Add missing status codes to logs #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faustinoaq
changed the title
robacarp
approved these changes
May 30, 2018
eliasjpr
reviewed
Jun 10, 2018
src/amber/pipes/logger.cr
Outdated
| @@ -52,11 +52,12 @@ module Amber | |||
| private def http_status(status) | |||
| case status | |||
| when 200 | |||
| text = "200 ".colorize(:green) | |||
| status.colorize(:green) | |||
There was a problem hiding this comment.
I thought I left a comment on this. Lets use range instead.
case status
when 200..299 then status.colorize(:green)
when 300..399 then status.colorize(:blue)
when 400..499 then status.colorize(:yellow)
when 500..599 status.colorize(:red)
else status.colorize(:white)
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add missing status codes to logs and some code cleanup
Alternate Designs
No
Benefits
Fixes #829
Possible Drawbacks
No