Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes no such file or directory #969

Merged
merged 1 commit into from Oct 29, 2018
Merged

Fixes no such file or directory #969

merged 1 commit into from Oct 29, 2018

Conversation

faustinoaq
Copy link
Contributor

Description of the Change

Changes name variable by directory variable when --deps is used.

Alternate Designs

  1. Do remove --deps flag?
  2. Do not change name to be underscore?

Benefits

Fixes #968

Possible Drawbacks

None AFAIK

@faustinoaq faustinoaq requested a review from a team October 29, 2018 18:54
@faustinoaq faustinoaq added this to To Do in Framework 2018 via automation Oct 29, 2018
@drujensen drujensen merged commit dd6430c into master Oct 29, 2018
Framework 2018 automation moved this from To Do to Done Oct 29, 2018
@drujensen drujensen deleted the fa/fix-no-such-directory branch October 29, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drujensen drujensen drujensen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Framework 2018
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@faustinoaq @drujensen